Current dependencies on/for this PR:

• main
  • PR Lex Jupyter Magic in assignment value position #30
    • PR Avoid lexing magic command when not an identifier #39 👈
      • PR Add line magic stmt and expr AST nodes #31

This comment was auto-generated by Graphite.

Right, if we don't allow this (current PR), then we can't allow an empty command either:

%
!

Earlier, we were lexing it with an empty string.

I'm kinda leaning towards allowing this while lexing as it's not a parse error from IPython but a usage error which we could highlight and fix using Ruff:

1. % foo would be:

   MagicCommand {
   	value: " foo",
   	kind: Magic,
   }

   The linter would check if the command value starts with any whitespace and throw a violation. The fix would be to remove them.

2. % would be:

   MagicCommand {
   	value: "",
   	kind: Magic,
   }

   The linter would check if the command value is empty or not. The fix would be remove the statement.

\cc @MichaReiser @konstin

can't judge this, i defer to micha

I'm kinda leaning towards allowing this while lexing as it's not a parse error from IPython but a usage error which we could highlight and fix using Ruff:

Sounds reasonable to me. It also seems a plus to give consistent error messages

Sounds reasonable to me. It also seems a plus to give consistent error messages

Thanks! Closing this.